Skip to content

add a miter limit on scattergeo #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexcjohnson opened this issue Sep 8, 2017 · 0 comments
Closed

add a miter limit on scattergeo #1995

alexcjohnson opened this issue Sep 8, 2017 · 0 comments
Assignees
Labels
bug something broken

Comments

@alexcjohnson
Copy link
Collaborator

Cartesian scatter lines have a miter limit of 2 https://github.com/plotly/plotly.js/blob/master/src/traces/scatter/plot.js#L42

This is important for sharp turns in the data for two related reasons:

  • with only lines, it looks like the data point is more extreme than it really is
  • with markers+lines, the line seems to poke through the marker and then leave from the same side it came from:
    screen shot 2017-09-08 at 3 52 39 pm
    (in case it's not clear: this is a black point on a red line on an existing scattergeo trace)

We should add this to scattergeo too, and investigate whether any other trace types need it. I suspect not though: scatterternary and scattercarpet inherit from regular scatter so should already have it, and the others are all webgl (cc @dfcreative I think we discussed this already at some point, it's at the very least a completely different kind of implementation)

cc @etpinard

I'll also note (in case this question comes up regarding any other trace types) that for contour lines we chose an even shorter miter limit of 1, because even if you specify no smoothing these are always modeling the data as if it were continuous and smooth - so we want to round off even sort-of-sharp corners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

2 participants