Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanitize all subplot attribute names #2007

Closed
alexcjohnson opened this issue Sep 15, 2017 · 1 comment
Closed

sanitize all subplot attribute names #2007

alexcjohnson opened this issue Sep 15, 2017 · 1 comment

Comments

@alexcjohnson
Copy link
Collaborator

From @etpinard in #1999 (comment) - we've added a lot of stuff and not all of it is handled equivalently in cleanLayout / cleanData. Do we want to?

We should perhaps try to sanitize all subplots attribute names in cleanLayout. Looks like we only sanitize cartesian, gl2d and gl3d axes at the moment.
@etpinard etpinard mentioned this issue Feb 7, 2018
Merged
@etpinard etpinard mentioned this issue Apr 4, 2018
Closed
@etpinard
Copy link
Contributor

etpinard commented Mar 28, 2019 •
edited
Loading

Closing. Probably not worth adding more things to cleanData and cleanLayout at this stage if we're planning on 🔪 them in v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcjohnson @etpinard