Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust handling of drag/hover interplay #2120

Closed
alexcjohnson opened this issue Oct 25, 2017 · 1 comment
Closed

More robust handling of drag/hover interplay #2120

alexcjohnson opened this issue Oct 25, 2017 · 1 comment
Labels
bug something broken

Comments

@alexcjohnson
Copy link
Collaborator

Right now we do some things to disable hover interactions during drag - dragElement uses gd._dragged for example, and pie looks at this to prevent hover if you drag over a pie from a cartesian subplot. But there are likely other subplot types that don't do this, and anyway this will do nothing to detect dragging over the plot from outside the plot entirely (which currently causes hover events - hence the bug label). Seems like we could do better by just looking at event.buttons.

see #2117 (comment)

Also from a chat with @monfera

I like the generalization idea, and an incredibly minor point is that how the drag is initiated feels circumstantial - now it's a mouse gesture with buttons; maybe in the future, there'd be other ways that are useful. The question is, do we want to disable receipt of certain input based on the use of affordances (e.g. mouse buttons here), or based on something ongoing in the chart? E.g. a scrollyteller or some real-time shared plot could have data driven dragging. I told you it's a minor point 😃

Also I think we want to disable it for the specific cursor (mouse) that's doing the dragging, again in a hypothetical dystopian future, you could drag something with one finger and hover (or drag) with some others

@gvwilson
Copy link
Contributor

Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

2 participants