Skip to content

Range slider emits relayout evt on mousemove, should be only on mouseup #2216

@gregorybleiker

Description

@gregorybleiker

I have had the need to do something after the rangeslider had changed (update the min/max somewhere else on the page). I did not find any event that fired only after the slider had been released (a.k.a. mouseup) so I changed the rangeslider/draw.js:

function mouseUp() {
            dragCover.removeEventListener('mousemove', mouseMove);
            dragCover.removeEventListener('mouseup', mouseUp);
            Lib.removeElement(dragCover);
// --> new code
            gd.emit('plotly_rangesliderend', {
                axis: axisOpts,
                opts: opts
// --> end new code
            });

Is this anything that would be merged? Should I do a PR?

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3backlogbugsomething broken

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions