-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
open items uncovered during Plotly.react push #2353
Comments
Referencing https://github.com/plotly/plotly.js/pull/2341/files#r166474049 about possibly improving implied edits. Pasting content from https://github.com/plotly/plotly.js/pull/2341/files#r166675758:
Perhaps all we need is to (under a certain config option) log whenever we mutate user data or user layout. Alternatively, Plotly.validate([{
y: [1, 2, 1]
}], {
xaxis: {
autorange: true,
range: [1, 2]
}
}) could log something like: increasing range detected, range values ignored under autorange. Then together with #1741, it should make it fairly easy for plotly.js users to debug. |
Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson |
Some rules that were good ideas before but become crucial with
Plotly.react
so that we recognize a non-change correctly:supplyDefaults
step - for example reshaping 1D to 2D arrays. That should be done in acalc
step and NOT pushed back into_fullData
.supplyDefaults
, unless you're going to push the results back to the input (data
/layout
) as well, likeautorange
/range
._full*
, always make_private
attributes.Most of the instances of this are taken care of in #2341, but a few are open:
tick0
,dtick
-> default filled in late (After SD) - also for tickmode=array, not needed at allcamera
doesn’t push back into_fullLlayout
after drag, onlylayout
?scatter3d
with uneven or missing x/y/zsurface
with uneven, missing, or ragged x/y/zautocolorscale
: first time it gets set on, second time off - is that intentional? cauto sometimes shows a similar effect… seegl3d_scatter-color-mono-and-palette
resolved in: Don't mutate colorscale, cmin/cmax and zmin/zmax into user traces #3341contourcarpet
:zmin
/zmax
get filled in (aftersupplyDefaults
) but they aren't actually attributes ofcontourcarpet
. They should be!autorange: 'reversed'
should get replaced inlayout
once it has been acted on. There's a polar mock where this doesn't happen until the second draw.The text was updated successfully, but these errors were encountered: