Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Click' events not working on 'Touch' in bar chart #2639

Closed
tropys opened this issue May 16, 2018 · 3 comments
Closed

'Click' events not working on 'Touch' in bar chart #2639

tropys opened this issue May 16, 2018 · 3 comments
Labels
bug something broken

Comments

@tropys
Copy link

tropys commented May 16, 2018

'Click' and 'Touch' work fine for pie charts but, only 'Click' works for bar chart.
If 'Touch' is not supported why does it work for pie charts?

Tested using chrome and firefox, emulated and on a touch screen.

Pie vs Bar chart codepen: https://codepen.io/steph_curried/pen/RyYmxL

@alexcjohnson
Copy link
Collaborator

Yes, that should work, thanks for the report! Seems like it should also show hover labels on the bar, wouldn't you think?

Even the pie has some behavior (on my phone anyway) that I wouldn't have expected: the first touch on a slice shows hover data and the second touch on that same slice makes a click event. @etpinard is that intentional? I guess I could imagine a rationale for that - otherwise there's no way to see the hover info without generating a click, which may be a stronger interaction than the user intended - but it still feels weird to me. Anyway, we should pick a behavior and have all trace/subplot types follow it.

@alexcjohnson alexcjohnson added the bug something broken label May 16, 2018
@etpinard
Copy link
Contributor

etpinard commented May 16, 2018

Anyway, we should pick a behavior and have all trace/subplot types follow it.

Right, picking the right behavior isn't obvious to me. It would be nice to see what other graphing libraries are doing. See #1858

Related: #1967

@etpinard
Copy link
Contributor

The 'click on bars' part is essentially a duplicate of #1967 and will be in fixed in #2997

The single vs double touch click idea is now in #1858 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

3 participants