Skip to content

Replace "dataScale" hack in 3D subplots #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
etpinard opened this issue May 18, 2018 · 1 comment
Closed

Replace "dataScale" hack in 3D subplots #2646

etpinard opened this issue May 18, 2018 · 1 comment
Labels
bug something broken

Comments

@etpinard
Copy link
Contributor

From #2641 (comment)

We should spend some time replacing this dataScale hack. This thing was added to make date axes work properly in 3D. Timestamps don't fit in a Float32Array, so we can't just convert the datestrings to timestamps, but we do this better in scattergl, where we use Float64Array or split the data into two Float32Arrays when not supported.

Fixing this should improve autorange results and make incorporating upcoming gl-vis components much easier!

@gvwilson
Copy link
Contributor

Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

3 participants