Skip to content

Multi-line legend items are positioned incorrectly #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
john-soklaski opened this issue Feb 25, 2016 · 4 comments
Closed

Multi-line legend items are positioned incorrectly #284

john-soklaski opened this issue Feb 25, 2016 · 4 comments
Labels
bug something broken

Comments

@john-soklaski
Copy link
Contributor

Multi-line legend items are positioned as if they were single-lined:
http://codepen.io/john-soklaski/pen/MygKjM

Debugging through, I found that this happened because the bounding box for the text element was calculated as if the text was all in one line.

I've fixed this in my fork by forcing a recalculation of the legend text's bounding box (though I'm not sure if it is the correct solution):
john-soklaski@855d25c

@etpinard etpinard added the bug something broken label Feb 25, 2016
@etpinard
Copy link
Contributor

Thanks for the report.

Could you test your case against master ?

@mdtusz made a few modifs in #243 that may have already fixed this issue.

@mdtusz
Copy link
Contributor

mdtusz commented Feb 25, 2016

Correct. This appears to be fixed by #243 in the master branch and will be solved in the next release.

@etpinard
Copy link
Contributor

Fixed in v1.6.0: http://codepen.io/etpinard/pen/ONPNXo

@john-soklaski
Copy link
Contributor Author

This is fantastic, thank you :)
It works great for me, and I'm liking the scroll-able legend as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

3 participants