-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Description
There are a bunch of attributes that we insert in the schema, and largely include in _fullData for all trace types. But many trace types don't support all of these attributes. As a simple workaround in @jonmmease's parcats PR, 273d2d0 (following @etpinard's suggestion #2963 (comment)) hides a the ones parcats doesn't use from the schema, but they will still show up in _fullData.
As I said in #2963 (comment):
There's a module
categories: ['noOpacity']which prevents coercingopacity(so it's not infullData, which is important for the editor) but does not take it out of the schema (and anyway only handlesopacity). @etpinard 's solution would fix the schema but notfullData. Sounds like what we really want is something like:module.omitGlobalAttrs: ['selectedpoints', 'hoverlabel', 'opacity', 'ids', 'customdata']that would do both.
There are probably quite a few other traces that omit some of these - in fact, probably everything that sets
traceOut._length = nullhas no use forselectedpoints,ids, andcustomdata...
And @etpinard responded #2963 (comment):
Good point here. But I think for this PR my suggestion in #2963 (comment) will be good enough. The react-chart-editor (aka RCE) doesn't know how to handle traces with
dimensionsyet, so having a few extra keys in fullData won't affect anyone at this stage. But yeah, once merged we should open a new issue (similar to #2834 and #2908) about this.
So here's that issue :)