Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotly 1.42.1 goes unresponsive #3197

Closed
rfriedma opened this issue Oct 31, 2018 · 5 comments · Fixed by #3199
Closed

Plotly 1.42.1 goes unresponsive #3197

rfriedma opened this issue Oct 31, 2018 · 5 comments · Fixed by #3199
Assignees
Labels
bug something broken

Comments

@rfriedma
Copy link

rfriedma commented Oct 31, 2018

I recently updated from plotly 1.41 to 1.42.1 in order to get some bug fixes. With the same data, plotting is now going unresponsive. I have two links below showing the same data in two versions of plotly where one hangs.
I'm using Chrome 70.0.3538.67 (Official Build) (64-bit)

Here's 1.42.1:
https://codepen.io/rfried/pen/VEJOJL

Here's 1.41.0:
https://codepen.io/rfried/pen/dgBxEg

Can anyone determine something wrong with my data or explain why plotly is hanging?

Thanks

@etpinard
Copy link
Contributor

Thanks very much for writing in.

Unfortunately, nothing comes to mind at first glance. We'll investigate.

@alexcjohnson
Copy link
Collaborator

there's a runaway while loop here:
screen shot 2018-10-31 at 2 27 42 pm

while(isNaN(srcPos[firstptdef]) || isNaN(srcPos[firstptdef + 1])) {
firstptdef += 2;
}
var lastptdef = srcPos.length - 2;
while(isNaN(srcPos[lastptdef]) || isNaN(srcPos[lastptdef + 1])) {
lastptdef += -2;
}

Came in with #3087
@archmoj want to take this?

@etpinard etpinard added the bug something broken label Oct 31, 2018
@etpinard
Copy link
Contributor

etpinard commented Oct 31, 2018

@archmoj I'm on it. I'll have a PR out shortly.

@rfriedma
Copy link
Author

Thanks for the quick response and fix :)

@etpinard
Copy link
Contributor

@rfriedma thank you for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants