Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'plotly_selected' fires undefined when plot is clicked subsequent to previous 'plotly_selected' #3248

Closed
cpsievert opened this issue Nov 15, 2018 · 3 comments

Comments

@cpsievert
Copy link

cpsievert commented Nov 15, 2018

Not sure if this is intentional, but I find it surprising, especially considering 'plotly_deselect' could be used to 'clear' a selection

https://codepen.io/cpsievert/pen/BGZQRx

weird

@etpinard
Copy link
Contributor

Yep, it's intended (for now):

// TODO: remove in v2 - this was probably never intended to work as it does,
// but in case anyone depends on it we don't want to break it now.
// Note that click-to-select introduced pre v2 also emitts proper
// event data when clickmode is having 'select' in its flag list.
gd.emit('plotly_selected', undefined);

Ok, if I move this to the v2 checklist in #420 ?

@cpsievert
Copy link
Author

Sounds good to me, thanks!

@etpinard
Copy link
Contributor

Moved to #420 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants