-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wishlist for potential breaking changes since v1 #420
Comments
On my list:
var plot = Plotly.createPlot('graph', data, layout, config);
plot.restyle(/* */);
plot.relayout(/* */);
plot.resize();
// ...
|
Ooooooh boy.
edit: April 14
edit: April 22
edit: April 26
edit: May 3rd
|
Besides agreeing with the above two lists, based on very limited work, take it with huge grain of salt:
|
To add to @monfera's testing comments - I'm personally not a fan of tests that just test the internal workings of code - they end up being quite brittle and often only ensure that code remains the way it was originally written. I'd love to see tests specific to plotting only use the public API and inspect the returned object - if we no longer keep state in the DOM, this will be infinitely easier as well and rendering tests can be handled separately using mocks (and obviously, maintain unit tests for well specified functions) . As well - without the need for a real browser DOM, we'd be able to run tests (excluding image tests) headless! |
This seems like a good place to discuss smooth transitions as well (requested in #142, and experimented with in plotly/plotly.R#547). It'd be awesome if
Also, in my mind, transitioning positions (x/y) is the most important use case, so it'd be super useful if
There are multiple ways to transition a path, but I think I'd almost always want to transition the transform. |
|
+💯 |
Remove our |
Revamp our set of default colorscales. |
⬆️ there is palette overlap between |
Drop Use e.g: // to add a blank annotation:
Plotly.relayout(gd, 'annotations[2]', {});
// to remove a shape:
Plotly.relayout(gd, 'shapes[2]', null); |
Maybe we should drop |
@etpinard 👍 for removing unofficial exposed methods. |
|
In principle this allows us to also change log axis ranges to data values backward-compatibly, since you can't make a log axis without explicitly specifying the container. The only downside I see to this is attribute names are a bit overloaded: |
I'd vote for the opposite. Rename all axis ids |
I'd vote for not having "names" that require parsing at all - put them as indexed elements in a list. |
That could work. It gives us the same simplification, clears up the ambiguity, and is a smaller change for users to adapt to. Means we have to do something more clever to manage backward compatibility but maybe that's unavoidable.
Like
|
Proposal from @etpinard, came up during stacked area #2960:
I might even go one step further, now that we have |
PR #2944 added |
#3044 may serve as a model for this kind of behavior, using |
From #3248
plotly.js/src/plots/cartesian/select.js Lines 258 to 262 in 3a32ac0
|
We're going to do this in (at least) 4 major releases next year instead of one massive major release. Will have a lot to celebrate by next year's holiday party! Roughly:
Giving these items plenty of time so that the Chart Studio, Dash, and Plotly.py teams have time to adjust to each major change. //cc @jonmmease @etpinard @alexcjohnson @nicolaskruchten @chriddyp @bpostlethwaite |
From #3450 (comment) (and cc #3553):
|
Any plans to support react-native? I found a third party dev who build this: https://github.com/rynobax/react-native-plotly any thoughts? |
Hi - is this still active? Is there an updated roadmap/release date for 2.0.0? Is there RC/branch we could try out? |
@nite sorry for the lack of update in this issue. We chose to prioritize new chart types (#2221) this year. We're still searching for a large company or consortium of companies to sponsor a v2 plotly.js API: https://plot.ly/products/consulting-and-oem/ |
The project is no longer developing? |
Very much still developing, in fact we released v2.0.0 last summer and by now we're up to v2.8.3. 2.0 didn't include everything in this wishlist, but it got some of them. Looks like we never updated this issue afterward though. @archmoj is this issue still useful? Perhaps we could rename it to "breaking changes wishlist" and check off the items that were completed with 2.0? Or, because the thread here is so long, perhaps it'd be better to close this issue and open a new one that collects the pieces of this one that are still relevant? |
@alexcjohnson Good call. I checked the boxes and renamed the issue. |
any plan to support React Native ? |
Leave this text box for planned improvements
d3
to v4.0.0 (now v5) - should be mostly a matter of updating the general update pattern.es-promise
polyfill from bundle - and thus make IE users add their own Promise polyfill.Annotations
,Shapes
,RangeSlider
, ...) register-able and remove them from the core bundle.config.plot3dPixelRatio
map for backward compatibilityPlotly.Snapshot.toImage
and mergesrc/snapshot
inplot_api/to_image.js
lib/core.js
- see Add registry of component modules #845Plotly.relayout
handlers for the'remove'
and'add'
special values - see Consistent container update / removal #1086layout
express everything in data units instead of linearized units. This applies torange
,tick0
, and annotation and image positions.xaxis2
vsx2
) probably by only using the name.'cross'
->'cross-thin'
(i.e. revert c0eb065)The text was updated successfully, but these errors were encountered: