You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a very high cardinality data set that I am trying to store only in typed arrays. Plotly already accepts typed arrays for the data.x and data.y values, which is great. However, I want to color the points based on the groups they belong to, and I would like to store those groups in a typed array as well. So instead of:
I looked at the code, and it seems to be as easy as changing the line 175 in groupby.js from: if(!(Array.isArray(groups)) || groups.length === 0) {
to something like: if(!(Array.isArray(groups) || groups.constructor === Uint8Array) || groups.length === 0) {
would this be doable? Thanks!
The text was updated successfully, but these errors were encountered:
Yes that would be doable. Thanks for pointing this out.
I would personally vote for accepting all typed arrays using Lib.isArrayOrTypedArray for consistency with the other array-typed-array logic in this library.
@danieljblinick would you be interested in making a PR for us?
I have a very high cardinality data set that I am trying to store only in typed arrays. Plotly already accepts typed arrays for the
data.x
anddata.y
values, which is great. However, I want to color the points based on the groups they belong to, and I would like to store those groups in a typed array as well. So instead of:it would be
I looked at the code, and it seems to be as easy as changing the line 175 in groupby.js from:
if(!(Array.isArray(groups)) || groups.length === 0) {
to something like:
if(!(Array.isArray(groups) || groups.constructor === Uint8Array) || groups.length === 0) {
would this be doable? Thanks!
The text was updated successfully, but these errors were encountered: