Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static-eval security issue reported by npm audit #4407

Closed
goldengecko opened this issue Dec 4, 2019 · 4 comments
Closed

Static-eval security issue reported by npm audit #4407

goldengecko opened this issue Dec 4, 2019 · 4 comments

Comments

@goldengecko
Copy link

To reproduce, install plotly.js in a project, and run npm audit.

Expected outcome: no security issues.
Actual outcome: reports an issue due to the version of static-eval linked to in the package.
Fix: update the static-eval version to >= 2.0.2. See https://www.npmjs.com/advisories/758

There are 16 security alerts generated, but they all refer to the same issue, as shown in the attached image.

Screen Shot 2019-12-04 at 12 03 31 pm

@etpinard
Copy link
Contributor

etpinard commented Dec 4, 2019

Duplicate of scijs/cwise#19

@etpinard etpinard marked this as a duplicate of scijs/cwise#19 Dec 4, 2019
@etpinard etpinard closed this as completed Dec 4, 2019
@Ionaru
Copy link

Ionaru commented Mar 27, 2020

@etpinard You are referring to an issue that is 2 years old, the PR ( scijs/cwise#25 ) that is meant to fix the security vulnerability has had no meaningful update or discussion since Jul 25, 2019.

At this point I think it's fair to assume the vulnerability will not be fixed at cwise's side, and I suggest looking into alternatives.

Ionaru added a commit to Ionaru/EVIE that referenced this issue Mar 30, 2020
Maybe re-evaluate when plotly/plotly.js#4407 is resolved.
@stephanvierkant
Copy link

Why is this issue closed? There are still security issues with cwise.

They may not cause direct issues with this repo, but at some point a non-maintained dependency with security issues should be fixed or replaced.

@nicolaskruchten
Copy link
Contributor

We're tracking this in #4796 now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants