-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
ScatterGL plot fails with WebGL errors if more than 16 symbols are used. #4628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Do you think it is a regression? |
Yep, I tested with Chrome (80.0.3987.132) on Win 10 x64. Also tested with Firefox 74.0 with the same results. |
Could you please investigate if this is a regression? |
I went back through previous versions and it looks like it started around 1.33.0 or 1.34.0. I didn't get the errors with 1.32.0. |
Sounds like this has probably been a bug since the gl2d rewrite in regl #2258 two years ago. |
From the changelogs, I would guess that's probably right. We didn't notice the problem in our app until it started to be used in production, since no one thought to test it with data that created that many symbols at once. :-/ |
And, again, this only seems to trigger during selection, so it's even less obvious. Not sure if that narrows it down at all, and I'm not sure yet if any other actions trigger it beyond selecting. I'll see if I can find out. |
Unsurprisingly, enabling the lasso select also triggers the WebGL errors. I couldn't trigger it with other modebar actions though. So it seems limited to selection as far as I can tell. |
@archmoj sorry it took a bit to return to this, but trying out latest (1.54.5), still seeing the issue. In addition, as number of symbols goes up, more and more points are not displayed. Hover data points to them, but the points themselves are not shown. Updated repro: http://jsfiddle.net/brian428/d7oh4j2m/ |
This issue has been tagged with A community PR for this feature would certainly be welcome, but our experience is deeper features like this are difficult to complete without the Plotly maintainers leading the effort. Sponsorship range: $10k-$15k What Sponsorship includes:
Please include the link to this issue when contacting us to discuss. |
@jackparmer I totally understand the idea of sponsorship for requests for new features and so on, but in case you didn't realize it, this is a bug (and a regression), not a feature request. Was adding the "needs sponsor" tag a mistake in this case? Thanks. |
This is intentional in this case: we're unlikely to be able to fix this one without external sponsorship unfortunately. |
Hi - we are trying to tidy up the stale issues and PRs in Plotly's public repositories so that we can focus on things that are still important to our community. Since this one has been sitting for several years, I'm going to close it; if it is still a concern, please add a comment letting us know what recent version of our software you've checked it with so that I can reopen it and add it to our backlog. Thanks for your help - @gvwilson |
Using plotly-latest, a ScatterGL plot will fail and throw WebGL errors if more than 16 symbols are used in the plot.
Repro case can be found at: http://jsfiddle.net/brian428/d7oh4j2m/
I tested and found that the magic number seems to be 16. With 16 symbols, the plot seems to work fine. With 17 symbols, large numbers of WebGL errors appear. For reference, the errors say:
Not sure if it matters, but I'm using the latest Chrome (80.0.3987.132) on Win 10 x64. Also tested with Firefox 74.0 with the same results.
The text was updated successfully, but these errors were encountered: