Skip to content

[Dependencies] box-interesect installation error #5966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FernandezMathieu opened this issue Oct 4, 2021 · 5 comments · Fixed by #6004
Closed

[Dependencies] box-interesect installation error #5966

FernandezMathieu opened this issue Oct 4, 2021 · 5 comments · Fixed by #6004
Milestone

Comments

@FernandezMathieu
Copy link

Hello,

My company is running into an issue with the latest versions of plotly.js (> 2.5).
We are installing the package through jupyterlab-plotly and are running into dependency issues.

Indeed, plotly.js is installing the box-intersect package directly from github (amongst many other packages), which is not accessible through our company CI network.

This behavior is very problematic as we cannot find a workaround yet.
We have tried installing locally the dependencies, yet npm still tries to reach for github and fails the installation. Event installing plotly.js 2.4.X fails, because npm will detect a higher version.

Possible solutions :

  • Restrict versions of plotly.js in jupyterlab-plotly more strictly.
    At the moment, jupyterlab-plotly references plotly.js too loosely, and always allows for version 2.5 to be installed. ^2.4.2 -> ~2.4.2
  • Publish the many dependencies to npm rather than fetching them direclty from github.
@archmoj
Copy link
Contributor

archmoj commented Oct 4, 2021

Please consider using 'plotly.js-dist' or 'plotly.js-dist-min' packages instead of 'plotly.js'.

@FernandezMathieu
Copy link
Author

FernandezMathieu commented Oct 4, 2021

Thanks @archmoj, unfortunately we already tried, but the command jupyter labextension install jupyterlab-plotly fetch plotly.js and try to install it even if 'plotly.js-dist' or 'plotly.js-dist-min' are installed.
Even if i installed them with the alias "plotly.js"

@archmoj
Copy link
Contributor

archmoj commented Oct 4, 2021

@nicolaskruchten could we change this line to dist?
https://github.com/plotly/plotly.py/blob/ce0ed07d872c487698bde9d52e1f1aadf17aa65f/packages/javascript/jupyterlab-plotly/package.json#L68

@sathish-akasapu
Copy link

Hi, we are also facing the same issue with plotly.js (> 2.5) with box-intersect when running npm install prod version from docker file.
We are using plotly.js with angular-plotly.js
The package worked fine with local build.
I observed some of the packages were pointing to github urls in package-lock.json file

For now we reverted to old version (~2.4.2) and working fine with it.

@archmoj archmoj added this to the v2.6.0 milestone Oct 29, 2021
@nicolaskruchten
Copy link
Contributor

Should be fixed with 2.6 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants