Skip to content

Fix Michigan #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexcjohnson opened this issue Sep 2, 2016 · 2 comments · Fixed by #1077
Closed

Fix Michigan #899

alexcjohnson opened this issue Sep 2, 2016 · 2 comments · Fixed by #1077
Assignees
Labels
bug something broken
Milestone

Comments

@alexcjohnson
Copy link
Collaborator

Choropleths of US states - like https://plot.ly/~Dreamshot/8177/gun-control-google-search-volume-by-us-state-since-2004/ - draw states with their borders out in the great lakes. Which is where their jurisdictional borders are, but this is not so useful or meaningful to viewers.

screen shot 2016-09-02 at 12 01 58 pm

This looks OK at the national level (gives a seamless border between US and Canada) but not at the state level. We should use the land outlines. This will affect all the great lakes states a little bit (MN, WI, IL, IN, OH, PA, NY) but Michigan has a totally different shape and size if you include the lakes.

The docs show a workaround using showlakes but this shouldn't be necessary, and still doesn't look exactly as you'd want - for this type of map you shouldn't see the border lines out in the water, and there should be lines at the water's edge:

screen shot 2016-09-02 at 12 34 37 pm

Globally I only see one other place we could consider doing this: Lake Victoria (Uganda, Tanzania, Kenya) but it's still not as big a change to the countries involved, and searches for eg "Tanzania Outline" and "Africa Choropleth" show that people don't seem to care too much one way or the other (but I will defer to locals, if any would like to chime in)

@etpinard etpinard added the bug something broken label Sep 2, 2016
@etpinard etpinard self-assigned this Sep 2, 2016
@etpinard
Copy link
Contributor

etpinard commented Oct 14, 2016

@alexcjohnson I think I fixed the problem in sane-topojson.

Here's the USA scope at resolution: 110 with showcountries: true and showlakes: false (i.e. the default look):

image

with showcountries: false and showlakes: false:

image

with showcountries: false and showlakes: true:

image

with showcountries: true and showlakes: true:

image

👍 / 👎 ❓

@alexcjohnson
Copy link
Collaborator Author

Huge improvement - love it!

Can we set showcountries: false by default when the scope is just the USA? This would extend to any other single-country scope we might add in the future too...

@etpinard etpinard added this to the v1.19.0 milestone Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants