issue #1160 fix #1161
Closed
issue #1160 fix #1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we play with timestamps, we have to leave range bounds integers
|
Thanks for submitting a PR! Looking like your patch unfortunately breaks zoom for non-date axes. I'll look for a better solution. This bug is most likely a side-effect of #1078 |
|
Yes, we can check if ax.type === 'date' then round the range |
|
@adamborowski @alexcjohnson I think 683d38a would be the most robust way to fix this issue. @adamborowski to make sure your work is rewarded, I'll apply the above commit on top of your d7de2ae commit, add a few tests and make another PR. Thanks very much for your efforts 🍻 |
|
replaced by #1162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we play with timestamps, we have to leave range bounds integers