- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.9k
Fix bar marker color array legend style #1289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            6 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      5d0d930
              
                look in calcdata item for 'mc' and 'mlc' in bar legend style
              
              
                etpinard 733d2b3
              
                rm calcdata items logic in box legend style
              
              
                etpinard 2877c3d
              
                add legend to bar_marker_array mock
              
              
                etpinard 6de37ee
              
                lint (rm unused var)
              
              
                etpinard 8e718bf
              
                fix legend for bar array marker line width
              
              
                etpinard 81d3db1
              
                test array marker.line.color in bar marker array mock
              
              
                etpinard File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -19,9 +19,26 @@ | |
| "#447adb", | ||
| "#db5a44", | ||
| "#447adb" | ||
| ] | ||
| ], | ||
| "line": { | ||
| "width": [ | ||
| 2, | ||
| 3, | ||
| 2, | ||
| 3 | ||
| ], | ||
| "color": [ | ||
| "red", | ||
| "green", | ||
| "blue", | ||
| "yellow" | ||
| ] | ||
| } | ||
| }, | ||
| "type": "bar" | ||
| } | ||
| ] | ||
| ], | ||
| "layout": { | ||
| "showlegend": true | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. | ||
| } | ||
| } | ||
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A thing of beauty :)