Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear axis types on some restyle calls #1295

Closed
wants to merge 1 commit into from
Closed

Clear axis types on some restyle calls #1295

wants to merge 1 commit into from

Conversation

etpinard
Copy link
Contributor

which allows for example to restyle histogram x from one axis type to another:

gifrecord_2017-01-11_175650

In detail, Axes.clearTypes is called during restyle in this block. At the moment, the attributes that trigger an Axes.clearTypes call are the following:

[ 'type', 'x', 'y', 'x0', 'y0', 'orientation', 'xaxis', 'yaxis' ]

anything missing?

@etpinard etpinard added status: in progress bug something broken labels Jan 11, 2017
@etpinard
Copy link
Contributor Author

See current behavior here: http://codepen.io/etpinard/pen/oBxxpE

@etpinard
Copy link
Contributor Author

Closing. We'll come up with a better solution as part of #1850

@etpinard etpinard closed this Jul 19, 2017
@etpinard etpinard deleted the restyle-clear-axis-types branch July 19, 2017 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@etpinard