Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the promise resolution to address IE11 bug #1691

Merged
merged 2 commits into from
May 16, 2017
Merged

Move the promise resolution to address IE11 bug #1691

merged 2 commits into from
May 16, 2017

Conversation

HenryKeen
Copy link
Contributor

@HenryKeen HenryKeen commented May 16, 2017 •
edited
Loading

Addresses issue #1685

Fixes a bug with IE11 - when images are specified in the layout, the promise is never resolved from the draw() function.

plotly.newPlot(elem).then(function(){
    //never hit
});

@etpinard
Copy link
Contributor

Thanks for the PR 🎉

Can you run npm run lint-fix and push again?

@etpinard etpinard added status: reviewable bug something broken labels May 16, 2017
@etpinard
Copy link
Contributor

Thanks very much!

This will be part of v1.27.1 set to be released this week.

@etpinard etpinard merged commit a729acc into plotly:master May 16, 2017
@etpinard etpinard mentioned this pull request May 16, 2017
Closed
@HenryKeen HenryKeen deleted the fix-ie11-image-promise branch May 17, 2017 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HenryKeen @etpinard