Skip to content

Conversation

etpinard
Copy link
Contributor

Another bug I found when working on gl3d annotations.

On scene drag/pan, we fire a plotly_relayout event mocking the equivalent Plotly.relayout call that would generate the current view.

Previously, the mocked event data looked:

{ scene: { eye: {/**/}, up: {/**/}, center: {/**/} }

(or scene2: // ... for multiple-scene graphs) which isn't compatible with our plot schema

Now with this PR, the mocked event data is:

{ 'scene.camera': { eye: {/**/}, up: {/**/}, center: {/**/} }

cc @monfera

- so that it looks like a 'real' relayout call.
@etpinard etpinard added status: reviewable bug something broken labels May 25, 2017
@alexcjohnson
Copy link
Collaborator

nice catch! 💃

@etpinard etpinard merged commit 78b82b8 into master May 26, 2017
@etpinard etpinard deleted the fixup-camera-interaction-relayout-event-data branch May 26, 2017 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants