Skip to content

Reuse font_attributes in table #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2017
Merged

Reuse font_attributes in table #2070

merged 2 commits into from
Oct 6, 2017

Conversation

monfera
Copy link
Contributor

@monfera monfera commented Oct 6, 2017

As in #2056

@monfera monfera mentioned this pull request Oct 6, 2017
Closed
21 tasks
@monfera monfera self-assigned this Oct 6, 2017
alexcjohnson
alexcjohnson approved these changes Oct 6, 2017
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💃

@etpinard
Copy link
Contributor

etpinard commented Oct 6, 2017

There's another one here:

plotly.js/src/traces/table/attributes.js

Line 217 in 6075d86

font: {

@monfera monfera merged commit adf3b03 into master Oct 6, 2017
@monfera monfera deleted the table-fontAttrs branch October 6, 2017 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

@etpinard etpinard Awaiting requested review from etpinard

Assignees

@monfera monfera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monfera @etpinard @alexcjohnson