Allow 1D header in table
#2072
Merged
Allow 1D header in table
#2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
alexcjohnson
reviewed
Oct 6, 2017
src/traces/table/defaults.js
Outdated
| traceOut.header.values[i] = [traceOut.header.values[i]]; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This makes me vaguely uneasy - having a different structure of the attribute in data vs _fullData. For example, the workspace looks at _fullData for what the current values are in order to construct controls, but then feeds control output back into data. It might be fine, but if there's a way to push this farther down, into data_preparation_helper perhaps, that would make me more comfortable.
alexcjohnson
approved these changes
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An item in #2056
One mock updated to show its use.