Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer fix #2121

Merged
merged 5 commits into from
Oct 27, 2017
Merged

Layer fix #2121

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
af9f8f9
move layer: above shapes and images to toppaper
alexcjohnson Oct 25, 2017
0162797
move updatemenus to their own layer above infolayer
alexcjohnson Oct 25, 2017
5039aa5
fix shape editing
alexcjohnson Oct 26, 2017
4e627d9
fix updatemenu test
alexcjohnson Oct 26, 2017
e0a10af
keep dropdown button container on top when new menus are added
alexcjohnson Oct 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/shapes/draw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ function draw(gd) {
function drawOne(gd, index) {
// remove the existing shape if there is one.
// because indices can change, we need to look in all shape layers
gd._fullLayout._paper
gd._fullLayout._paperdiv
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really we should just move shapes (and annotations for that matter) to the standard d3 update pattern like images already use (and which did not require this kind of change to adapt to the changed layering)... but that's a bigger project than I had an appetite for right now!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but that's a bigger project than I had an appetite for right now!

Fixing two 🪲 in one PR, but hungry for more 🍔

.selectAll('.shapelayer [data-index="' + index + '"]')
.remove();

Expand Down