Fix legend items aligning #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you share the |
|
Here is a demo: |
|
Looks great - thanks! Can you confirm that your patch does not impact https://codepen.io/anon/pen/RGozGE from #960 ? Moreover, would you mind adding an image test mock to lock down your bug fix? |
|
Confirm. It doesn't impact #960. Here is a demo with my changes: https://codepen.io/plotly-demo/pen/RjgJdR. Added image test. |
|
Very lovely PR and test. Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes legend items (trace names) aligning in horizontal legends if all in one row, related to #1193 and #960 and does not affect group legends and multi row legends.
Before
After