adding layout.colorway #2156
adding layout.colorway #2156
Conversation
|
To add the baseline corresponding to your new mock, see If you're having issues with our docker image-test container, let us know. |
| valType: 'colorlist', | ||
| dflt: colorAttrs.defaults, | ||
| role: 'style', | ||
| editType: 'calc', |
There was a problem hiding this comment.
Comment for future development: note here that only pie traces require this to be editType: 'calc'. For most trace types, editType: 'plot' would have sufficed and even editType: 'style' might have been good enough for cartesian traces. Oh well, we might have to add-trace-type-specific editType flags for layout attributes down the road to improve performance.
| "labels": ["a","b","c","c","c","a","d","e","f","f","g","h"], | ||
| "type": "pie", | ||
| "domain": {"x": [0, 0.4]}, | ||
| "xaxis": "x2", |
There was a problem hiding this comment.
xaxis and yaxis don't do anything for pie traces. Would you mind 🔪 them?
| "domain": [0.4, 1] | ||
| }, | ||
| "yaxis": { | ||
| "anchor": "y2" |
There was a problem hiding this comment.
anchor for y-axes expects x-axis ids, so this thing here gets ignored. 🔪
| @@ -141,6 +141,22 @@ exports.valObjectMeta = { | |||
| else propOut.set(dflt); | |||
| } | |||
| }, | |||
| colorlist: { | |||
There was a problem hiding this comment.
Would you mind adding a Lib.validate test case for the new colorlist valType?
|
A very lovely addition ❤️ Thanks very much @cixzhang 🎉 |
For #2136
This PR adds the
layout.colorwayattribute which takes a list of colors to use as the default set of colors for all traces. By default, it should use the existingColor.defaults.