allow use of element ID in Plots.resize #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and make sure the resize tests actually DO something
alexcjohnson
commented
Dec 18, 2017
| @@ -369,7 +370,7 @@ describe('Test Plots', function() { | |||
| .then(done); | |||
| }); | |||
|
|
|||
| afterEach(destroyGraphDiv); | |||
| afterAll(destroyGraphDiv); | |||
There was a problem hiding this comment.
Oops, if we're doing beforeAll we'd better match it with an afterAll! The second test (should resize...) didn't consider that it might be running against a missing plot (mainSvgs.length was 0) so was in fact a noop. The third test (should update...) I guess was OK, gd was still an object with properties even if it wasn't attached to the DOM...
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also
Plots.redrawTextwhile we're at it - this is the other one inPlotsthat might occasionally need to be called from outside.cc @etpinard @VeraZab