Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean subplots #2227

Merged
merged 17 commits into from
Jan 3, 2018
Merged

Clean subplots #2227

merged 17 commits into from
Jan 3, 2018

Commits on Dec 22, 2017

  1. refactor calcdata filtering 

    more efficient, DRY, and without the hack of basePlot.attr='type'
    @alexcjohnson
    alexcjohnson committed Dec 22, 2017
    Configuration menu
    Copy the full SHA
    687a2e2 View commit details
    Browse the repository at this point in the history

  2. perf xaCheater/xaNonCheater test in cartesian axes defaults

    @alexcjohnson
    alexcjohnson committed Dec 22, 2017
    Configuration menu
    Copy the full SHA
    9a18062 View commit details
    Browse the repository at this point in the history

  3. lint cartesian layout_defaults

    @alexcjohnson
    alexcjohnson committed Dec 22, 2017
    Configuration menu
    Copy the full SHA
    2c9d90f View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2017

  1. rework subplot logic - create subplots from traces and components only 

    not from axes and scenes. So if you make axes or scenes and then change
the trace types, the old ones will not appear.
    @alexcjohnson
    alexcjohnson committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    3625be4 View commit details
    Browse the repository at this point in the history

  2. update baselines for improved subplot logic 

    a few just have different rounding, but most were actually wrong before
    @alexcjohnson
    alexcjohnson committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    2de217e View commit details
    Browse the repository at this point in the history

  3. wider acceptance range for png toimage test 

    so it passes on my mac
    @alexcjohnson
    alexcjohnson committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    b94ad8e View commit details
    Browse the repository at this point in the history

  4. update trans keys

    @alexcjohnson
    alexcjohnson committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    c88e8c2 View commit details
    Browse the repository at this point in the history

  5. fix typo in cameraposition -> camera cleaning

    @alexcjohnson
    alexcjohnson committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    26aaffc View commit details
    Browse the repository at this point in the history

  6. updated gl3d "cameraposition" baselines

    @alexcjohnson
    alexcjohnson committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    276d1d3 View commit details
    Browse the repository at this point in the history

  7. 🔪 unused import

    @alexcjohnson
    alexcjohnson committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    c49007e View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2017

  1. 🔪 commented out code

    @alexcjohnson
    alexcjohnson committed Dec 30, 2017
    Configuration menu
    Copy the full SHA
    698561c View commit details
    Browse the repository at this point in the history

  2. Object.keys -> for in, in plots/plots

    @alexcjohnson
    alexcjohnson committed Dec 30, 2017
    Configuration menu
    Copy the full SHA
    8804311 View commit details
    Browse the repository at this point in the history

  3. simplify redundant title removal

    @alexcjohnson
    alexcjohnson committed Dec 30, 2017
    Configuration menu
    Copy the full SHA
    4786b6e View commit details
    Browse the repository at this point in the history

  4. get rid of unneeded _has(gl2d)

    @alexcjohnson
    alexcjohnson committed Dec 30, 2017
    Configuration menu
    Copy the full SHA
    6e62b35 View commit details
    Browse the repository at this point in the history

  5. use _subplots in Axes.list/listIds

    @alexcjohnson
    alexcjohnson committed Dec 30, 2017
    Configuration menu
    Copy the full SHA
    0506f88 View commit details
    Browse the repository at this point in the history

  6. simplify and speed up a few Axes.list uses 

    in particular, annotations autorange was including 3d axes, and axes we already knew didn't have annotations.
    @alexcjohnson
    alexcjohnson committed Dec 30, 2017
    Configuration menu
    Copy the full SHA
    2aa1545 View commit details
    Browse the repository at this point in the history

  7. fix annotation calc_autorange change 

    need to filter out (x|y)ref='paper'
    @alexcjohnson
    alexcjohnson committed Dec 30, 2017
    Configuration menu
    Copy the full SHA
    44060db View commit details
    Browse the repository at this point in the history