Speed up selection #2295
Merged
Speed up selection #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexcjohnson please take a look. |
|
Nice, can't argue with the 🐎 ! Only suggestion would be 🌴 something like selectedOptions = makeModifiedMarkerOptions(trace.selected.marker, markerOpts);
unselectedOptions = makeModifiedMarkerOptions(trace.unselected.marker, markerOpts); |
|
@alexcjohnson done, thank you for the good point! |
|
@alexcjohnson should that be a good-to-go? |
|
💃 |
ivankirshin
pushed a commit
to newcrom/plotly.js
that referenced
this pull request
Jan 30, 2024
ifdotpy
added a commit
to newcrom/plotly.js
that referenced
this pull request
Feb 5, 2024
plotly#2295: Front: Prepare package for publication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes multimarker selection error (@bpostlethwaite discussion) and speeds up entering selection mode (up to ×3 times).