-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for (hover) 'text' in mesh3d traces #2327
Conversation
Not sure how much you want to let this PR expand, but here's a definitely-a-bug that popped up as I was trying out your PR: Also it looks like |
@alexcjohnson good catch. Thanks. I think I fixed them all in 8ae2d0e by overriding the |
8ae2d0e looks great, thanks for the tests 🔒 |
Oops. I pushed too soon. That's in d20bdc1 |
src/traces/surface/attributes.js
Outdated
role: 'info', | ||
dflt: '', | ||
arrayOk: true, | ||
editType: 'calc', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this is in an overrideAll
so you don't need editType
- which I think applies to a few more of the additions in this PR too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I see you 🔪 some editType
lines, just not the one I made the comment directly on 😅 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Fixed in -> 13a3ecf
Nice - slowly getting all these trace types up to par with each other. 💃 |
Call this a bug fix or a new feature, this PR closes #2242