Break circular refs in old fullData and fullLayout #2366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to help garbage collection
|
huh, this causes some problems in the tests... will need to investigate. |
|
hmm, after some more testing I no longer think this is a significant benefit, and the test errors make it clear this was an overly blunt approach anyway - if there is a benefit to be had here, it'll be better to target exactly the items known to contain possible circular references, such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @etpinard @dfcreative This doesn't seem to be the whole story, but it does look like it helps the garbage collector in repeated-restyle workloads like #1755