fall back for contour labels when there's only one contour #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also break up Axes.calcTicks -> prepTicks only finishes setting up the axis object
|
Looks good 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2398 - the test case I added is the simplest distillation of the plot in the initial report.
Also: I broke up
Axes.calcTicks-> newprepTicksonly finishes setting up the axis object (tick0,dtick,_tickround, and_tickexponent- all the thingsAxes.tickTextwill need), but does not actually calculate all the ticks. This is potentially a noticeable improvement for constraint-type contours, where I set an arbitrarily largenticksmerely to ensure we get a reasonable number of digits of precision. Carpet can take advantage of this as well in one place.cc @etpinard