-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
WIP: Legend Scrolling #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
32fa3cd
Remove some plotly dependency
mdtusz b55b501
Add legend type attribute
mdtusz 7cfec79
Add scrollbox (not yet set to be active though)
mdtusz a4dc092
Add sensible default
mdtusz b4e2796
Remove legend type attribute
mdtusz 91a68b5
Add scrollbar
mdtusz 61fa606
Remove some plotly dependency
mdtusz c3ba270
Add legend type attribute
mdtusz 803e797
Add scrollbox (not yet set to be active though)
mdtusz c24b29b
Add sensible default
mdtusz 23f6073
Remove legend type attribute
mdtusz b45e846
Add scrollbar
mdtusz 811f925
Add drag scroll, move scroll code to `draw`, fix weird width bug
mdtusz e66ab81
Change svg element to g
mdtusz 36c3a69
Add tests for scrolling
mdtusz 81cf841
Change bg style changes to attrs for ff compatiblity
mdtusz 44fb3c7
Update image baselines
tarzzz d7124f4
Add final drawing step
mdtusz 4e752fb
Add data-bb removal code to svg_text_utils
mdtusz 20fbf18
:space_invader: fix sloppy mistake
mdtusz 82dbfcc
Update scroll test to work in ff and chrome
mdtusz a170ec7
Add comment explaining finalDraw function
mdtusz ff92f21
Add box-sizing to legend background
mdtusz 8ddf644
Add crisp rendering and gutter for scollbar
mdtusz fee87db
update baselines
etpinard 0a3ebd9
Merge branch 'master' into dropdown-filter
etpinard f1bdea0
update plot_types mock (due to sub-pixel legend modifs)
etpinard 1df89c5
add tolerance of 1e-6 to pixel comparison tests
etpinard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
'use strict'; | ||
|
||
module.exports = { | ||
scrollBarWidth: 4, | ||
scrollBarHeight: 20, | ||
scrollBarColor: '#808BA4', | ||
scrollBarMargin: 4 | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How hard would it be to factor in
ry
in the legend width calculation so that e.g.does not overlap long legend items?