Skip to content

WIP: Legend Scrolling #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Feb 22, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
32fa3cd
Remove some plotly dependency
mdtusz Jan 25, 2016
b55b501
Add legend type attribute
mdtusz Jan 25, 2016
7cfec79
Add scrollbox (not yet set to be active though)
mdtusz Feb 5, 2016
a4dc092
Add sensible default
mdtusz Feb 5, 2016
b4e2796
Remove legend type attribute
mdtusz Feb 5, 2016
91a68b5
Add scrollbar
mdtusz Feb 8, 2016
61fa606
Remove some plotly dependency
mdtusz Jan 25, 2016
c3ba270
Add legend type attribute
mdtusz Jan 25, 2016
803e797
Add scrollbox (not yet set to be active though)
mdtusz Feb 5, 2016
c24b29b
Add sensible default
mdtusz Feb 5, 2016
23f6073
Remove legend type attribute
mdtusz Feb 5, 2016
b45e846
Add scrollbar
mdtusz Feb 8, 2016
811f925
Add drag scroll, move scroll code to `draw`, fix weird width bug
mdtusz Feb 10, 2016
e66ab81
Change svg element to g
mdtusz Feb 11, 2016
36c3a69
Add tests for scrolling
mdtusz Feb 11, 2016
81cf841
Change bg style changes to attrs for ff compatiblity
mdtusz Feb 11, 2016
44fb3c7
Update image baselines
tarzzz Feb 12, 2016
d7124f4
Add final drawing step
mdtusz Feb 16, 2016
4e752fb
Add data-bb removal code to svg_text_utils
mdtusz Feb 16, 2016
20fbf18
:space_invader: fix sloppy mistake
mdtusz Feb 16, 2016
82dbfcc
Update scroll test to work in ff and chrome
mdtusz Feb 17, 2016
a170ec7
Add comment explaining finalDraw function
mdtusz Feb 17, 2016
ff92f21
Add box-sizing to legend background
mdtusz Feb 17, 2016
8ddf644
Add crisp rendering and gutter for scollbar
mdtusz Feb 18, 2016
fee87db
update baselines
etpinard Feb 19, 2016
0a3ebd9
Merge branch 'master' into dropdown-filter
etpinard Feb 22, 2016
f1bdea0
update plot_types mock (due to sub-pixel legend modifs)
etpinard Feb 22, 2016
1df89c5
add tolerance of 1e-6 to pixel comparison tests
etpinard Feb 22, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/components/legend/constants.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
'use strict';

module.exports = {
scrollBarWidth: 4,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How hard would it be to factor in ry in the legend width calculation so that e.g.

image

does not overlap long legend items?

scrollBarHeight: 20,
scrollBarColor: '#808BA4',
scrollBarMargin: 4
};
Loading