Added missing 'Saturday' string to locale-en

[vdh]

For some reason days is missing everyone's favourite one 😉

[etpinard]

Thanks! Did that lead to any noticeable bugs?

[vdh]

@etpinard Well from what I've seen trying to use i18n, it doesn't look like the locale settings have been used anywhere yet?

[alexcjohnson]

Ha, good catch, wonder how we missed that? This will only show up with %A in a custom format, and we don't test every possible day and month in each format. We have some related tests in lib_date_test - would you mind adding one that covers all the weekdays?

[vdh]

@alexcjohnson I tried writing a test, but I wasn't able to figure out how to connect the locale-en file to the test.

[alexcjohnson]

Ah you're right, sorry about that - we've just used d3.time.format.utc in lib_date_test, you don't get locales until you've done a supplyDefaults step. We've got some related tests in localize_test, we can probably model it off this one - but it's a little more involved than I had realized, I can take it if you want.

[vdh]

Yeah thanks, I'm a bit lost. Sorry about the late reply by the way.

[alexcjohnson]

Added tests that cover the missing Saturday and most of the rest of the fields that should be in the locale. @etpinard OK?

[etpinard]

Great 💃