Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster axis autorange + remove calcIfAutorange edit type #2823

Merged
merged 15 commits into from
Aug 2, 2018
Merged

Faster axis autorange + remove calcIfAutorange edit type #2823

merged 15 commits into from
Aug 2, 2018

Commits on Jul 18, 2018

  1. pass dragbox element to mouseEvent 

    ... this reduces the occurance of intermittent failure in
    the gl2d_click suite on etpinard's laptop
    @etpinard
    etpinard committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    9c2be8d View commit details
    Browse the repository at this point in the history

  2. fixup "role" for ax autorange and rangemode

    @etpinard
    etpinard committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    c9711dc View commit details
    Browse the repository at this point in the history

  3. sub fail -> failTest

    @etpinard
    etpinard committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    bd61c54 View commit details
    Browse the repository at this point in the history

  4. run Axes.expand on autorange: false axes 

    - this way `relayout(gd, 'ax.autorange', true)` does not have
  to go through costly editType "calc"
- this makes the 'calcIfAutorange' edit type obsolete,
  which the following few commits will cope with
    @etpinard
    etpinard committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    b1911b3 View commit details
    Browse the repository at this point in the history

  5. handle splom Axes.expand calls w/ undefined xa/ya

    @etpinard
    etpinard committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    35d501d View commit details
    Browse the repository at this point in the history

  6. adapt and 🔒 annotations to 'calcIfAutorange'-less edits!

    @etpinard
    etpinard committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    a8fb653 View commit details
    Browse the repository at this point in the history

  7. remove unused '_' fields in annotations full items

    @etpinard
    etpinard committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    6e19c6e View commit details
    Browse the repository at this point in the history

  8. 🔒 marker.size calc + autorange edit behavior

    @etpinard
    etpinard committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    4e8ff28 View commit details
    Browse the repository at this point in the history

  9. swap and 🔒 'calcIfAutorange' -> 'calc' for shapes

    @etpinard
    etpinard committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    c75cda8 View commit details
    Browse the repository at this point in the history

  10. swap and 🔒 'calcIfAutorange' -> 'calc' for box attributes

    @etpinard
    etpinard committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    8f23ef5 View commit details
    Browse the repository at this point in the history

  11. fix and 🔒 ohlc tickwidth edits

    @etpinard
    etpinard committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    a326778 View commit details
    Browse the repository at this point in the history

  12. 🔪 calcIfAutorange logic in Plotly methods 

    ... including the refAutorange block which is no longer
    necessary.
    @etpinard
    etpinard committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    138a84f View commit details
    Browse the repository at this point in the history

  13. try ax autorange as 'axrange' edit type

    @etpinard
    etpinard committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    1c40947 View commit details
    Browse the repository at this point in the history

  14. lint / fix comment

    @etpinard
    etpinard committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    026cd53 View commit details
    Browse the repository at this point in the history

  15. 🔪 obsolete _rangesliderAutorange field 

    ... this was used to not skip Axes.expand when ax autorange was false,
    but range slider range wasn't set.
    @etpinard
    etpinard committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    1cdc36b View commit details
    Browse the repository at this point in the history