Bound scalar marker size in legend item #2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- setting d.ms isn't enough here, as downstread in Drawing.pointStyle subtypes.isBubble is used to determine if d.ms or trace.marker.size is used to draw the legend item.
|
Huh, I thought we already did that. Anyway yes, this is good. 💃 |
|
OK great, I think this should be part of 1.40.0, not 1.39.3 though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2833, but does affect a handful of our baselines.
@alexcjohnson what do you think? Were scaler
marker.sizevalues supposed to remain unbounded in legend items?