Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-trace axis extremes #2849

Closed
wants to merge 26 commits into from

Commits on Jul 25, 2018

  1. Configuration menu
    Copy the full SHA
    67db333 View commit details
    Browse the repository at this point in the history
  2. add findExtremes

    - a Axes.expend clone that does not append things to ax._min/ax._max,
      but instead returns two arrays, a min array and max array
      of potential data extremes
    etpinard committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    3e817f3 View commit details
    Browse the repository at this point in the history
  3. add _extremes to all traces in calc

    - to be filled with the results of findExtremes
    etpinard committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    1cd8482 View commit details
    Browse the repository at this point in the history
  4. adapt getAutoRange and doAutoRange to trace _extremes

    - pass gd, to look for _extremes in gd._fullData and eventually
      in layout container to can expand the axis ranges
    etpinard committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    e9d3ca0 View commit details
    Browse the repository at this point in the history
  5. generalize concatExtremes for polar, splom and layout components

    - N.B. sploms are linked to multiple axes per traces, so we can't
      rely on single 'x' and 'y' in _extremes ->  use ax._id instead!
    etpinard committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    2966cf3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a9cf2e1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    13cb0f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2018

  1. replace Axes.expand -> findExtremes for ErrorBars

    - here we append the min/max arrays of the corresponding trace
    etpinard committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    d24eaef View commit details
    Browse the repository at this point in the history
  2. 🔪 ax._min / ax._max logic for rangeslider

    - questionable commit, especially the part in autorange.js,
      but this doesn't make any test fail ?!?
    etpinard committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    d9bb617 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9b02ac4 View commit details
    Browse the repository at this point in the history
  4. adapt polar to new per trace/item _extremes

    - N.B. polar is the only subplot apart from cartesian that
      used Axes.expand and friends.
    etpinard committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    d407c90 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9ab0c2f View commit details
    Browse the repository at this point in the history
  6. adapt gl2d to findExtremes

    etpinard committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    6e866c2 View commit details
    Browse the repository at this point in the history
  7. 🔪 Axes.expand

    etpinard committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    c45427b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e77cacc View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ba3c903 View commit details
    Browse the repository at this point in the history
  10. sub fail -> failTest

    etpinard committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    424f4a6 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4c250c3 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    5becba0 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2018

  1. use ax.(_traceIndices, annIndices, shapeIndices)

    ... to keep track of traces, annotations and shapes plotted on
        axis ax. Adapt concatExtremes accordingly!
    etpinard committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    66df51e View commit details
    Browse the repository at this point in the history
  2. fixups (from AJ's review)

    etpinard committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    d0699c0 View commit details
    Browse the repository at this point in the history
  3. add bar stack visible -> autorange test & move 'b' init to setPositions

    - Bar.setPositions mutate 'b' in bar trace calcdate, we need
      to reinit 'b' during setPositions so that we can skip
      calc on visible edits
    etpinard committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    f1cda60 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9a78013 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2018

  1. Revert "make annotations & shapes 'visible' -> 'plot' edit type"

    - we would need to coerce their xref and yref
      even when `visible:false`. Not worth the effort at
      the moment.
    
    This reverts commit 9a78013.
    etpinard committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    5cfee13 View commit details
    Browse the repository at this point in the history
  2. add fallback for _extremes during concat

    ... to handle `visible:false` annotations and shapes that
        do not go through calcAutorange at the moment.
    etpinard committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    62f1549 View commit details
    Browse the repository at this point in the history
  3. collapse trace extremes before getAutorange

    ... by factoring out logic from findExtremes
    etpinard committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    aac11a2 View commit details
    Browse the repository at this point in the history