Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging #2860 to master #2865

Merged
merged 22 commits into from
Aug 2, 2018
Merged

Merging #2860 to master #2865

merged 22 commits into from
Aug 2, 2018

Commits on Jul 31, 2018

  1. DRY and small pref boost for scattergl

    - DRY using .plot & .cleear with getViewport helper fn
    - Dry .plot and .update with repeat helper fn
    - compute viewport only once per subplot, as opposed to
      once per trace.
    etpinard committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    69dc0c4 View commit details
    Browse the repository at this point in the history
  2. push trace module into fullLayout._modules even if visible:false

    - so that gl-based trace can call their plot methods w/ an
      empty array of traces and just work.
    - update and improve scatterlg visibility tests to reflect
      that `restyle(gd,visible,false)` no longer clear the context
    etpinard committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    41ad08a View commit details
    Browse the repository at this point in the history
  3. fill in list of visible:true module in fullLayout._visibleModules

    - to not have to guard against visible!==true traces in _module.style
    - to shortcut full list of modules in other places downstream
    etpinard committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    9c8ba02 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8ef5cb3 View commit details
    Browse the repository at this point in the history
  5. sub fail -> failTest

    etpinard committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    cf0b19d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9cc5fbe View commit details
    Browse the repository at this point in the history
  7. add bar autorange tests & move 'b' init to setPositions

    - Bar.setPositions mutates 'b' in bar trace calcdata,
      so to reinit 'b' during setPositions so that it doesn't
      conflit with Bar.calc
    etpinard committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    dfada6a View commit details
    Browse the repository at this point in the history
  8. add findExtremes

    - a Axes.expend clone that does not append things to ax._min/ax._max,
      but instead returns two arrays, a min array and max array
      of potential data extremes
    etpinard committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    be44366 View commit details
    Browse the repository at this point in the history
  9. adapt getAutoRange and doAutoRange to trace _extremes

    - pass gd, to look for _extremes in gd._fullData and eventually
      in layout container to can expand the axis ranges
    etpinard committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    ad1ac1f View commit details
    Browse the repository at this point in the history
  10. fill trace._extremes with findExtremes in calc

    - replacing Axe.expand
    - for ErrorBars, we append the min/max arrays
      of the corresponding trace
    etpinard committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    769c160 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    736ab69 View commit details
    Browse the repository at this point in the history
  12. 🔪 ax._min / ax._max logic for rangeslider

    - questionable commit, especially the part in autorange.js,
      but this doesn't make any test fail ?!?
    etpinard committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    6194457 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    8cd06ae View commit details
    Browse the repository at this point in the history
  14. adapt polar to new per trace/item _extremes

    - N.B. polar is the only subplot apart from cartesian that
      used Axes.expand and friends.
    etpinard committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    2a745de View commit details
    Browse the repository at this point in the history
  15. adapt gl2d to findExtremes

    etpinard committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    82d4bcc View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    29db388 View commit details
    Browse the repository at this point in the history
  17. improve concatExtremes perf

    - by using ax.(_traceIndices, annIndices, shapeIndices),
      to keep track of traces, annotations and shapes plotted on
      axis ax. Adapt concatExtremes accordingly!
    etpinard committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    72f06a6 View commit details
    Browse the repository at this point in the history
  18. collapse trace extremes before getAutorange

    ... by factoring out logic from findExtremes
    etpinard committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    a0bfaf3 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2018

  1. mv repeat -> Lib.repeat

    etpinard committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    33b4085 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d233f3b View commit details
    Browse the repository at this point in the history
  3. fix typos in 📚

    etpinard committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    89aebd1 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2018

  1. Merge pull request #2860 from plotly/per-trace-ax-extremes-maintenance

    Recycled commits from abandoned fast trace toggle PRs
    etpinard authored Aug 2, 2018
    Configuration menu
    Copy the full SHA
    20db59a View commit details
    Browse the repository at this point in the history