setPositions -> crossTraceCalc #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and set_positions.js files -> cross_trace_calc.js
alexcjohnson
reviewed
Aug 3, 2018
src/traces/histogram/index.js
Outdated
| @@ -12,7 +12,7 @@ | |||
| /** | |||
| * Histogram has its own attribute, defaults and calc steps, | |||
| * but uses bar's plot to display | |||
| * and bar's setPositions for stacking and grouping | |||
| * and bar's crossTraceCalc (formally known as setPositions) for stacking and grouping | |||
|
Looks great, thanks for doing that! 💃 after fixing the little typo 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as requested by @alexcjohnson
setPositionsis currently only used for bar, histogram, box and violin traces, but will soon (cc #2867 and #2810) be used in non-cartesian subplots and not just to set positions but a few other "cross-trace" things.