Scatter3d attributes fixups #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so that we the list correct behavior, before implementing them
as features.
alexcjohnson
reviewed
Aug 7, 2018
| if(!opts.noScale) { | ||
| // handle both the trace case where the dflt is listed in attributes and | ||
| // the marker case where the dflt is determined by hasColorbar | ||
| var showScaleDftl; |
There was a problem hiding this comment.
you want to fix this typo while you're at it? 😄
|
Looks good, thanks for doing this. Comment is nonblocking. 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few
scatter3dattributes are not listed properly as mentioned in #2872 and #2862.This PR corrects them while we wait until #2872 and #2862 get implemented as features.
cc @alexcjohnson