A slightly less ambitious take on orphan subplots and 'delete last trace' #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- by keeping track of traces in each geo from call to call, - make sure that its module's plot method is called so that it is properly removed from the DOM.
- ensures the deleted geos are only properly removed from the DOM. - ensures the deleted contour, heatmap and colorbar are properly removed
- make sure that graphs with only orphan cartesian are
considered 'cartesian'
- make sure that axes associated with GL2D traces aren't
considered 'cartesian'
- by making layout with { xaxis: {}, yaxis: {} } a 'hasCartesian'
plot, deleting the last cartesian trace retains the axes.
- now the geo is delete upon deleting the last trace
etpinard
changed the title
|
Looks good to me. I'm not quite sure whether this represents a temporary situation or the way we will keep it long-term, but given the convoluted logic that can arise I'm starting to think it's clearer for everyone if orphan subplots are simply not drawn. |
etpinard
added a commit
that referenced
this pull request
Feb 29, 2016
A slightly less ambitious take on orphan subplots and 'delete last trace'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexcjohnson @mdtusz
An alternative to #268 .
Comment #268 (comment) made me realize that #268 was taking things a little too far.
This PR shares most commits with #268 but does not allow for orphan scenes and geos to be drawn. In other words, gl3d and geo subplots must be associated with a gl3d / geo trace respectively in order to be visible.
List of fixed bugs
Plotly.deleteTraceswhen applied to the last trace of a subplot now properly deletes that last tracePlotly.deleteTracesnow works on heatmap and contour traces (yep, that didn't work before)Plotly.deleteTracesnow works on surface and mesh3d tracesPlotly.deleteTracesnow properly delete color bars associated with deleted tracesPlotly.deleteTracesnow works on geo tracesPlotly.relayout('graph', { 'xaxis': null, 'yaxis': null });delete the axes as desiredPlotly.deleteTracesnow works on pie traces