make sankey honor positioning specified by domain.x #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❇️ Brilliant ❇️ Not a bad day for @antoinerg scoring a 💃 hattrick |
alexcjohnson
reviewed
Sep 7, 2018
| @@ -172,7 +172,7 @@ function sankeyModel(layout, d, traceIndex) { | |||
| valueFormat: valueFormat, | |||
| valueSuffix: valueSuffix, | |||
| textFont: textFont, | |||
| translateX: domain.x[0] * width + layout.margin.l, | |||
| translateX: domain.x[0] * layout.width + layout.margin.l, | |||
There was a problem hiding this comment.
Man, sankey is so confusing... I was convinced this must be wrong but no, you got it exactly right, sankey just remapped _size into something that looks like _fullLayout and even called it layout for further obfuscation...
plotly.js/src/traces/sankey/plot.js
Lines 257 to 266 in ff3c324
If you ever feel like untangling a little of this, please do!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2878
Simple fix with a test to 🔒 this down!