Fix scattergl missing lines after non-line trace #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- which now doesn't skip over line traces after non-line traces - update two gl2d_text_chart baseline that suffer from this bug
- regl-line2d "skips" over "undefined"s, not "null"s
|
I'm going to go ahead and merge this so it is part of @ErwanMAS feel free to open a new issue if you notice any other issues. Thanks again for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by bumping regl-line2d to 3.0.11 which includes @dy's gl-vis/regl-line2d@513e867
For more info on this topic, see: gl-vis/regl-line2d#35
This PR fixes two
gl2d_text_chartbaselines (as first noted in #2737 (comment)).This PR also fixes: