Skip to content

Conversation

alexcjohnson
Copy link
Collaborator

@etpinard @antoinerg the perils of nested functions - I had started out reusing the variable name cd in the inner scope, then thought better of it and made a new local var calcTrace but didn't update all references...

@etpinard
Copy link
Contributor

Ah good catch. 💃

Maybe we should consider enabling https://eslint.org/docs/rules/no-shadow? That would require some work though, as no-shadow fails in more than 500 times in our codebase.

@alexcjohnson
Copy link
Collaborator Author

Maybe we should consider enabling https://eslint.org/docs/rules/no-shadow?

mmm, interesting, that's a good idea, I'll make a maintenance issue for it.

@alexcjohnson alexcjohnson merged commit ed39d82 into master Sep 17, 2018
@alexcjohnson alexcjohnson deleted the stacked-area-missing-data branch September 17, 2018 14:17
@etpinard etpinard mentioned this pull request Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants