Fix parcats + Plotly.react bug

[etpinard]

a follow-up on @jonmmease 's #2963, making Plotly.react result in a noop when reacting from the same parcats figure.

I noticed that one of our @noCI was failing, at first I thought that simply appending of test mock list would suffice, but no, we also needed to patch parcats to make that @noCI test pass.

While at it, I also added some tolerance here and there the make the whole suite pass on my setup.

cc @alexcjohnson

[alexcjohnson]

I also notice we sometimes overwrite displayindex during calc - presumably that can cause problems too?

plotly.js/src/traces/parcats/calc.js

Lines 463 to 470 in e43d0f8

	function validateDimensionDisplayInds(trace) {
	var displayInds = trace.dimensions.filter(visible).map(function(dim) {return dim.displayindex;});
	if(!isRangePermutation(displayInds)) {
	trace.dimensions.filter(visible).forEach(function(dim, i) {
	dim.displayindex = i;
	});
	}
	}

[jonmmease]

I’ll take a look this evening...

…

On Thu, Oct 4, 2018 at 4:32 PM alexcjohnson ***@***.***> wrote: I also notice we sometimes overwrite displayindex during calc - presumably that can cause problems too? https://github.com/plotly/plotly.js/blob/e43d0f85149570e9d8194bc1383ebd40465fdf9f/src/traces/parcats/calc.js#L463-L470 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3072 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOXdLUkppWlRyCVlFQRoeHE49EscLBuhks5uhnBmgaJpZM4XHDwE> .

[jonmmease]

Yeah, displayindex is overwritten if the user specified displayindex values are not consistent across dimensions. So perhaps we need to introduce an _displayindex property here as well.

I'm not very familiar with the react pathway yet, but let me know if there's anything here you'd like me to dig into. Thanks @etpinard!

[etpinard]

Yeah, displayindex is overwritten if the user specified displayindex values are not consistent across dimensions. So perhaps we need to introduce an _displayindex property here as well.

I'll take 👀

[etpinard]

So perhaps we need to introduce an _displayindex property here as well.

Done and 🔒 ed in 157a6e2

[alexcjohnson]

Thanks for taking this @etpinard - and @jonmmease thanks for chiming in.

Looks great. 💃

[jonmmease]

Thanks @etpinard!