Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Rotate axis labels that are longer than 4 characters in 3D scenes (issue #3077)" #3103

Closed
wants to merge 1 commit into from
Closed

Revert "Rotate axis labels that are longer than 4 characters in 3D scenes (issue #3077)" #3103

wants to merge 1 commit into from

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Oct 13, 2018 •
edited
Loading

Reverts #3084
If the dist files should not be modified by this commit?
4500ea3

@alexcjohnson
Copy link
Collaborator

Ah thanks - you're right, dist/ should only be updated on a new release here. But you don't need to revert the whole PR, just revert that one commit and then reapply the parts of it (package.json and package-lock.json) that belong.

@alexcjohnson
Copy link
Collaborator

superseded by #3104

@alexcjohnson alexcjohnson deleted the revert-3084-rotate3d-axis-lables branch October 13, 2018 15:35
This was referenced Oct 20, 2018
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @alexcjohnson