Fix scatter fill regression #3168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... by setting trace._ownfill on every linkTraces call,
so we don't let relinkPrivateKeys mess things up.
Previously, the scatter fill restyle test did not fail,
but did log a error as Drawing.fillGroupStyle logs
in a try-catch when things go wrong instead of errorring out.
|
Good catch! I noticed those logs but studiously ignored them 🙈 - glad someone is paying more attention!!
How does this 🔒 it?
Me too. We have enough tests at this point, don't worry about removing it. As evidenced here, a |
By spying on |
|
... by I removed that spy in the second commit 1f3c10c as now the |
|
Got it, thanks! 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an unreleased regression originating from #3087. I'd like to get this in before the 1.42.0 release.
Scatter fills on master currently do not restyle correctly and lead to these logs:
but no failed tests. That's because those logs come from:
plotly.js/src/components/drawing/index.js
Lines 201 to 207 in 0a310c9
which do not make
failTestthrow, leading to false-positive tests.The first commit fixes and 🔒s the bug, and the second commit 🔪s that try-catch (which is at least 4 years old) which is probably a bit more dangerous, but I'm willing to take that chance. I hope @plotly/plotly_js agrees.