Use paper_bgcolor for parcats text-shadow instead of hardcoding to white #3191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps category labels from becomming blurred when text is white on a black background
|
Definitely an improvement! I'm just wondering if we want to go one step further and make a new attribute ( |
|
I guess though if we want this to be categorized as a bugfix, so it can go in a patch, it should stand as is... |
|
Nice fix 💃 |
|
Looks like @jonmmease isn't online at the moment. I'll merge this in to make it part of 1.42.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to make parcats look good with a dark theme. Previously the SVG text shadow behind the category labels was hardcoded to white. But this makes the text unbearably blurry when the font is white and the background is dark:
This PR makes the text-shadow take on the color of the
paper_bgcolor. This doesn't change the appearance with a white background, but significantly improves the situation for dark background:This image is from a new
parcats_darkmock to 🔒 it in.What about Sankey?
The text shadow logic was largely borrowed from the
sankeytrace type, so I took a look at this trace on a black background as well.It looks like the
sankeytrace doesn't pick up it's default font color fromlayout.font.color, and it draws all node labels on top of paths, so it's default behavior still works reasonable well on a dark background. So I didn't make any changes to it.